Skip to content

Revert "style: wrap text code to prevent content overflow-x" #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

peterpeterparker
Copy link
Contributor

@peterpeterparker peterpeterparker commented Feb 5, 2025

Motivation

Revert PR #1325.

PR was 7 months old, and other CSS changes happened in the meantime, which made its style break some styles for the <code> block once applied today, as reported by @weihanglo.

Before #1325:

image

After:

image

Notes

I had a quick look, and it seems that the original issue addressed by #1325 in May 2024 still occurs on main when a long function is inside a code block within a list. This can now potentially be prevented with #1474.

@peterpeterparker peterpeterparker changed the title style: wrap text code to prevent content overflow-x Revert "style: wrap text code to prevent content overflow-x" Feb 5, 2025
@Turbo87 Turbo87 merged commit a0537db into rust-lang:master Feb 5, 2025
3 checks passed
@peterpeterparker
Copy link
Contributor Author

@Turbo87 Thanks! Could you also approve this leftover #1475? I missed it this morning. Apologies for the back and forth, really sorry.

@peterpeterparker peterpeterparker deleted the style/revert-code-display-block branch February 5, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants